Minecraft 1.21.4 #282
Open
Minecraft 1.21.4 #282
+387
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and gson deserialization attempted default value fix
need to rewrite uploadBuildResult
|
This PR is very promising, can't wait this PR to be merged & released! |
|
Doesn't seem to work with the latest voxy rewrite build for some reason, probably an issue on Voxy's side considering the fact it's still in development but probably also worth looking into. |
Open
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I updated to Minecraft 1.21.4/Sodium 0.6.9.
This update disable douira's sodium 0.6 translucency sorting to rely on nvidium's one.
Also, if you are lazy, beta builds here: https://github.com/drouarb/nvidium/releases
EDIT: Translucency sorting crash happens because of nvidium instantReschedule that can schedule a chunk for rebuild twice if async BFS is enabled. Sodium will eventually process twice a chunk that is newly generated and crash while trying to inject translucency data inside ChunkBuildOutput.
https://github.com/drouarb/nvidium/blob/181ed48f45179a0b12d231cc740eca5a714d495a/src/main/java/me/cortex/nvidium/mixin/sodium/MixinRenderSectionManager.java#L185
Maybe, nvidium instantReschedule could be removed but i'm unsure which issue it should be fixing and why it was introduced on first place. On my tests, there is no issues removing it.
Anyway for now, disabling translucency sorting seems to do the trick especially since nvidium doesn't use sodium translucency data.
I will still try to implement sodium translucency sorting inside nvidium, unsure if it will be better for performance.